RFC635: L2 Constructs for MediaConvert #639
Conversation
PavanRangudu
changed the title
| are optimized and aligned with recommended standards. | ||
|
|
||
| const genericMp4Hev1AvcAacSdrQvbJobTemplate = new JobTemplate(this, 'GenericMp4Hev1AvcAacSdrQvbJobTemplate', { | ||
| name: "GenericMp4Hev1AvcAacSdrQvbJobTemplate" |
There was a problem hiding this comment.
where are these templated maintained?
There was a problem hiding this comment.
My initial idea is to maintain (a copy of these system templates) inside CDK repo. Discussed offline with @moelasmar and pending implementation details.
| To create a Custom Job Template using an L2 Construct, you define the ``jobTemplateProps`` object, which includes all the | ||
| necessary settings for your media processing tasks. This object is then passed to the ``JobTemplate`` construct to create the custom template. | ||
|
|
||
| const jobTemplateProps: JobTemplateProps = { |
There was a problem hiding this comment.
how can customers define a template, will they write it in JSON format ?
There was a problem hiding this comment.
Yes, they can write it in a JSON format. We also discussed about having some helper methods to produce this props object. I plan to add some more details on it in my next commit.
|
|
||
| const presetProps: PresetProps = { | ||
| name: 'CustomPreset', | ||
| settings: { |
There was a problem hiding this comment.
Will the objects in this settings have types defined?
Same question to the settings in JobTemplateProps.
And in these 2 settings objects, are all fields required?
There was a problem hiding this comment.
Yes, my idea is to have strongly-typed fields for all of these interfaces by importing our SDK. Discussed offline with @moelasmar and @samson-keung and pending decision on whether we can use SDK inside CDK.
To your second que: no, not all fields are required. I plan to add respective interfaces (with fields marked as required/optional) in my next commit.
| Using System Presets like this allows you to leverage AWS MediaConvert’s best practices without needing to manually configure every encoding parameter, making your media processing workflows more efficient and reliable. | ||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Sure, I will add them in my next commit.
mergify
bot
dismissed
samson-keung’s stale review
Pull request has been modified.
This is a request for comments about MediaConvert L2 Constructs. See #{635} for additional details.
[TODO] APIs are signed off by @{BAR_RAISER}.
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache-2.0 license