docs: Remove TODOs from specification #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lavaleri
commented
Apr 26, 2023
| @@ -124,7 +122,7 @@ In DynamoDB, Set Entry Value can only be a [Value](#value) of the following type | |||
| - [Number](#number) | |||
| - [Binary](#binary) | |||
|
|
|||
| #### Map (TODO: Duvet currently can't handle headers named "Map") | |||
| #### Map Attribute | |||
There was a problem hiding this comment.
Created issue for duvet to fix this bug: awslabs/duvet#114
The workaround is not egregious enough to be worth tracking follow up on our side.
| @@ -358,8 +358,6 @@ this result. | |||
| If any [Decrypt Item](./decrypt-item.md) operation fails, | |||
| BatchGetItem MUST yield an error. | |||
|
|
|||
| TODO: Is there a way to make use of `UnprocessedKeys` to return a partial result? | |||
There was a problem hiding this comment.
Tracking this internally as a post-GA feature request, to be prioritized.
| @@ -112,8 +112,6 @@ followed by the length of the key, followed by the key as a UTF8 string. | |||
|
|
|||
| ### Encryption Context | |||
|
|
|||
| TODO: Link directly to the MPL definition once it is more generalized. | |||
There was a problem hiding this comment.
It is a good idea to have this format explicitly define how to serialize it's information.
| @@ -145,8 +143,6 @@ Each Key Value Pair MUST be serialized as follows | |||
|
|
|||
| ### Encrypted Data Keys | |||
|
|
|||
| TODO : This is the same as in ESDK and MPL. Should they be unified somehow? | |||
There was a problem hiding this comment.
It is a good idea to have this format explicitly define how to serialize it's information.
| @@ -63,8 +63,6 @@ String MUST be serialized as UTF-8 encoded bytes. | |||
| Number MUST be serialized as UTF-8 encoded bytes. | |||
| Note that DynamoDB Number Attribute Values are strings. | |||
|
|
|||
| TODO: consider fixed-length serialization for numeric types | |||
There was a problem hiding this comment.
Tracking this internally as a post-GA feature request, to be prioritized.
ajewellamz
approved these changes
Apr 27, 2023
texastony
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.