Fix OTA_Shutdown() not releasing resources

[vishwamartur]

Related to #1910

Modify otaThread function in demos/ota/ota_demo_core_http/ota_demo_core_http.c to release resources properly.

• Add pthread_detach(pthread_self()); to detach the thread.
• Add pthread_exit(NULL); to exit the thread.

[ActoryOu]

Hello @vishwamartur,
Thanks for your contribution! Could you help share your verification result with us as well?

[aggarg]

@vishwamartur Please describe how you tested these changes?

[AniruddhaKanhere]

Thank you @vishwamartur for this contribution.

I think there might be a race condition. What if detach is called before the line 2117 (pthread_join)? That will cause undefined behavior.

And I think when the thread exits, it automatically cleans the resources. We need not have to call kill - it is an extreme measure in my opinion.

Also, I am not sure why would we need both join and detach. Both of them are mutually exclusive.

Or maybe I failed to understand something. Can you please clarify?

[vishwamartur]

Hi @AniruddhaKanhere,

Thank you for highlighting the potential issues with pthread_detach and pthread_exit.

Since pthread_detach and pthread_exit are both being used, there is indeed a redundancy here. Calling pthread_exit will allow the thread to terminate and release resources, so adding pthread_detach isn't necessary and might even lead to undefined behaviour if the system tries to manage the thread's lifecycle in two ways.

I’ll update the code to use only pthread_exit(NULL); for cleanup, which should handle resource release upon thread exit without requiring pthread_detach.

Thanks again for catching this!

Best,
Vishwa