fix: support legacy arm platforms #478
Conversation
| "manylinux1_aarch64": "manylinux_2_5_aarch64", | ||
| "manylinux2010_aarch64": "manylinux_2_12_aarch64", | ||
| "manylinux2014_aarch64": "manylinux_2_17_aarch64", |
There was a problem hiding this comment.
Where did you get these mapping from?
There was a problem hiding this comment.
I was using this PR to test if my assumption is correct or not, and I marked it as draft, but seems I made it ready by mistake .. sorry for that .. I still need to work on it, it is not finalized
| @@ -103,6 +105,42 @@ def test_must_build_python_project(self): | |||
| output_files = set(os.listdir(self.artifacts_dir)) | |||
| self.assertEqual(expected_files, output_files) | |||
|
|
|||
| @skipIf(NOT_ARM, "Skip in windows tests") | |||
There was a problem hiding this comment.
We don't run arm tests (not sure why), but how are we verifying this works now and will work in the future?
Also the reason states "windows". I assume that is a copy paste error.
| { | ||
| "inflate64", | ||
| "inflate64.libs", | ||
| "inflate64-0.1.4.dist-info", |
There was a problem hiding this comment.
Not clear to me how this works with the mappings you added. Was inflate64 the issue or was it some other package? Looking at the downloadable whls form this version, I don't see any of the aarch64 whls there.
Issue #, if available:
#348
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.