fix: Use the fallback PKG-INFO file if the one generated manually is incomplete #523
Conversation
| """ | ||
| # default values logic: | ||
| # https://github.com/pypa/setuptools/blob/6083e18f4afc40316c0112134c205c336afbcdfd/setuptools/_distutils/dist.py#L1185-L1189 | ||
| return name == "UNKNOWN" or version == "0.0.0" |
There was a problem hiding this comment.
Should this be and? Doc string indicates and.
There was a problem hiding this comment.
Hmm, thats a good call out. This is an or, so the doc string should be updated. Reason why the version check is also included here is that the assumption is being made that the packages wouldn't have version 0.0.0. In any case, if it did it would just grab the fall back file (the one pip download generates with the build deps) and use what it has.
There was a problem hiding this comment.
Got it. Probably fine. I did a quick search and seems like most package versions start with 0.1.0 or 0.0.1. I am sure there are packages with 0.0.0 but we can always handle those in one offs.
The "safer" thing is probably doing a version check for 0.0.0 only if UNKNOWN is given but I think what you have is fine.
| if not self._is_default_setuptools_values(fallback_name, fallback_version): | ||
| name = fallback_name | ||
| version = fallback_version | ||
|
|
||
| return name, version |
There was a problem hiding this comment.
in case they are not the fallback name and version, what are they?
There was a problem hiding this comment.
If the fallback name or version turn out to also be the default values, then it will use the the initially determined values. Basically, no replacement logic will happen.
Issue #, if available:
#526
Description of changes:
Lambda Builders will invoke the
setup.pyfile of source packages to determine the name and version of a package. The PKG-INFO file generated could be incomplete (UNKNOWNname or0.0.0version). If either of these are found, then we'll fall back to the file that is generated bypip download.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.