Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed AwsResolver.CreateProperties() to use logical OR condition when checking for Amazon.Lambda.CloudWatchEvents.CloudWatchEvent type. #1780

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

ashishdhingra
Copy link
Contributor

@ashishdhingra ashishdhingra commented Jul 23, 2024

Issue #, if available: #634

Description of changes:
Fixed an issue AwsResolver.CreateProperties() to use logical OR condition when checking for Amazon.Lambda.CloudWatchEvents.CloudWatchEvent type.

Version bump to Amazon.Lambda.Serialization.Json has been done in PR #1779.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ashishdhingra ashishdhingra requested a review from normj July 23, 2024 23:26
@ashishdhingra ashishdhingra force-pushed the user/ashdhin/CloudWatchEvent_Issue634 branch from c79969b to 869af69 Compare July 24, 2024 01:13
… checking for Amazon.Lambda.CloudWatchEvents.CloudWatchEvent type.
@ashishdhingra ashishdhingra force-pushed the user/ashdhin/CloudWatchEvent_Issue634 branch from 869af69 to 4643309 Compare July 24, 2024 16:56
@ashishdhingra ashishdhingra changed the title Fixed an issue AwsResolver.CreateProperties() to use logical OR condition when checking for Amazon.Lambda.CloudWatchEvents.CloudWatchEvent type. Fixed AwsResolver.CreateProperties() to use logical OR condition when checking for Amazon.Lambda.CloudWatchEvents.CloudWatchEvent type. Jul 24, 2024
@afroz429 afroz429 requested a review from ashovlin July 30, 2024 17:30
@ashishdhingra ashishdhingra merged commit 7e1b1ab into dev Jul 30, 2024
6 checks passed
@ashishdhingra ashishdhingra deleted the user/ashdhin/CloudWatchEvent_Issue634 branch July 30, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants