Avoid attaching security groups to NLB in unsupported regions and fix integration tests #6448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanwen-pcluste
added
the
skip-changelog-update
hanwen-pcluste
changed the title
gmarciani
requested changes
Oct 2, 2024
hanwen-pcluste
changed the title
hanwen-pcluste
force-pushed
the
release-3.11oct2
branch
from
332ad4c
to
cb4de6c
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
NLB with security groups is a new feature added in 2023. However, the feature is not supported in ADC Signed-off-by: Hanwen <[email protected]>
… FSxOntap and FSxOpenZFS Prior to this commit, the logic was wrong and didn't skip Ontap and OpenZFS if Lustre is supported Signed-off-by: Hanwen <[email protected]>
…nd Ontap Signed-off-by: Hanwen <[email protected]>
iso regions don't support tagging certificates. Therefore, the condition in IAM policy is too restrictive in iso reginos Signed-off-by: Hanwen <[email protected]>
hanwen-pcluste
force-pushed
the
release-3.11oct2
branch
from
cb4de6c
to
fad9c79
Compare
gmarciani
reviewed
Oct 17, 2024
| @@ -708,9 +708,6 @@ Resources: | |||
| - iam:UploadServerCertificate | |||
| - iam:TagServerCertificate | |||
| Resource: !Sub arn:${AWS::Partition}:iam::${AWS::AccountId}:server-certificate/* | |||
| Condition: | |||
There was a problem hiding this comment.
Why are we removing this condition?
hgreebe
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits descriptions for details
Description of changes
Tests
References
Checklist
developadd the branch name as prefix in the PR title (e.g.[release-3.6]).Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.