Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fasthttp dependency to v1.52.0 #478

Merged

Conversation

ddouglas
Copy link
Contributor

Description of changes:
Update fasthttp dependency to version that does not include
the RSA Key that was in the repo for testing.
Those keys have been moved into the test files
as variables.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Update dependecy to version that does not include
the RSA Key that was in the repo for testing.
Those keys have been moved into the test files
as variables.
@ddouglas ddouglas requested a review from a team as a code owner October 31, 2024 19:20
@ddouglas
Copy link
Contributor Author

@vastin Apologies. I'm not sure what was wrong with my last branch, but I'm trying one more time with a fresh branch. This one has been tested inside of docker using golang 1.19 and 1.20 and passed with no issues.

Copy link
Contributor

@vastin vastin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. ty.

@vastin vastin merged commit 6d76caa into aws:master Oct 31, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants