-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test and accommodate Producer C CMake improvements #1154
base: develop-pre-3.4.1
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1154 +/- ##
===========================================
+ Coverage 16.48% 16.51% +0.03%
===========================================
Files 50 50
Lines 7019 7022 +3
===========================================
+ Hits 1157 1160 +3
Misses 5862 5862 ☔ View full report in Codecov by Sentry. |
@@ -7,7 +7,7 @@ include(ExternalProject) | |||
# clone repo only | |||
ExternalProject_Add(libkvscproducer-download | |||
GIT_REPOSITORY https://github.com/awslabs/amazon-kinesis-video-streams-producer-c.git | |||
GIT_TAG develop | |||
GIT_TAG cmake-cleanup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remember to change this back to /develop branch once Producer C PR is merged
Issue #, if available:
What was changed?
Why was it changed?
How was it changed?
What testing was done for the changes?
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.