Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test and accommodate Producer C CMake improvements #1154

Open
wants to merge 17 commits into
base: develop-pre-3.4.1
Choose a base branch
from

Conversation

stefankiesz
Copy link
Contributor

@stefankiesz stefankiesz commented Mar 17, 2024

Issue #, if available:


What was changed?

  • The path to open-source libraries will not longer have /local/ in it
  • This PR is used to test the Producer C CMake changes PR for compatibility

Why was it changed?

  • Removing /local/ from path makes this build tree uniform with the Producer C build, so the same Producer C can find it's built libraries whether built alone or as a dependency.

How was it changed?

  • /local/ was removed from the relevant places

What testing was done for the changes?

  • Built locally on Intel Mac and M2 Mac
  • The CI test suite

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.51%. Comparing base (eeb392f) to head (45c81b7).

❗ Current head 45c81b7 differs from pull request most recent head 65e7d2c. Consider uploading reports for the commit 65e7d2c to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1154      +/-   ##
===========================================
+ Coverage    16.48%   16.51%   +0.03%     
===========================================
  Files           50       50              
  Lines         7019     7022       +3     
===========================================
+ Hits          1157     1160       +3     
  Misses        5862     5862              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefankiesz stefankiesz changed the title CMake testing Test and accommodate Producer C CMake improvements Mar 22, 2024
@stefankiesz stefankiesz marked this pull request as ready for review March 22, 2024 18:51
@@ -7,7 +7,7 @@ include(ExternalProject)
# clone repo only
ExternalProject_Add(libkvscproducer-download
GIT_REPOSITORY https://github.com/awslabs/amazon-kinesis-video-streams-producer-c.git
GIT_TAG develop
GIT_TAG cmake-cleanup
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to change this back to /develop branch once Producer C PR is merged

@sirknightj sirknightj added CI build Changes to CMakeLists.txt labels Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Changes to CMakeLists.txt CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants