Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using prebuilt libkvscproducer through pkg-config #1193

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hacker1024
Copy link

Description of changes:

At the moment, the use of libkvscproducer does not respect -DBUILD_DEPENDENCIES. This PR allows it to be found via pkg-config instead of built from source.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sirknightj
Copy link
Contributor

Hi @hacker1024, thanks for your contribution.

We want to avoid breaking backwards compatibility. The behavior we want to make sure doesn't get broken, is that when running cmake .. -DBUILD_DEPENDENCIES=OFF after a fresh git clone, it still builds C producer (for a new user who doesn't have C producer cloned or built). I would suggest adding a new flag which build producer-c defaulting to ON to maintain this behavior.

In your PR description, could you also add how you tested it (which scenarios/commands you ran)?

Finally, could you change the target branch to develop? We'll merge develop into master branch during the next release cycle.

Looking forward to these enhancements!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Changes to CMakeLists.txt enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants