Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic version constant #109

Merged
merged 2 commits into from
Apr 18, 2024
Merged

Dynamic version constant #109

merged 2 commits into from
Apr 18, 2024

Conversation

sirknightj
Copy link
Contributor

@sirknightj sirknightj commented Apr 17, 2024 •
edited
Loading

Description of changes:

  • Pull the constant from build.gradle instead of hard-coding it.

Testing:

  • Run android (master) with JS (viewer) to confirm a peerconnection is still established and media is exchanged between the peers.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sirknightj sirknightj added the enhancement New feature or request label Apr 17, 2024
niyatim23
niyatim23 approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@niyatim23 niyatim23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

hassanctech
hassanctech approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@hassanctech hassanctech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@niyatim23 niyatim23 merged commit a8c9b6a into master Apr 18, 2024
4 checks passed
@niyatim23 niyatim23 deleted the version-constant branch April 18, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hassanctech hassanctech hassanctech approved these changes

@niyatim23 niyatim23 niyatim23 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sirknightj @hassanctech @niyatim23