chore: make CBMC stubs with zero parameters proper declarations (#1107)

verification/cbmc/include/proof_helpers/aws_byte_cursor_read_common.h

@@ -6,7 +6,7 @@
 #include <aws/common/byte_buf.h>
 #include <proof_helpers/make_common_data_structures.h>
 
-void aws_byte_cursor_read_common_harness() {
+void aws_byte_cursor_read_common_harness(void) {
     /* parameters */
     struct aws_byte_cursor cur;
     DEST_TYPE *dest = malloc(sizeof(*dest));

verification/cbmc/include/proof_helpers/make_common_data_structures.h

@@ -127,7 +127,7 @@ void hash_proof_destroy_noop(void *p);
 /**
  * Ensures a valid string is allocated, with as much nondet as possible
  */
-struct aws_string *ensure_string_is_allocated_nondet_length();
+struct aws_string *ensure_string_is_allocated_nondet_length(void);
 
 /**
  * Ensures a valid string is allocated, with as much nondet as possible, but len < max

verification/cbmc/include/proof_helpers/nondet.h

@@ -12,11 +12,11 @@
 /**
  * Non-determinstic functions used in CBMC proofs
  */
-bool nondet_bool();
-int nondet_int();
-size_t nondet_size_t();
-uint16_t nondet_uint16_t();
-uint32_t nondet_uint32_t();
-uint64_t nondet_uint64_t();
-uint8_t nondet_uint8_t();
-void *nondet_voidp();
+bool nondet_bool(void);
+int nondet_int(void);
+size_t nondet_size_t(void);
+uint16_t nondet_uint16_t(void);
+uint32_t nondet_uint32_t(void);
+uint64_t nondet_uint64_t(void);
+uint8_t nondet_uint8_t(void);
+void *nondet_voidp(void);

verification/cbmc/sources/make_common_data_structures.c

@@ -189,7 +189,7 @@ bool hash_table_state_has_an_empty_slot(const struct hash_table_state *const sta
  */
 void hash_proof_destroy_noop(void *p) {}
 
-struct aws_string *ensure_string_is_allocated_nondet_length() {
+struct aws_string *ensure_string_is_allocated_nondet_length(void) {
     /* Considers any size up to the maximum possible size for the array [bytes] in aws_string */
     return nondet_allocate_string_bounded_length(SIZE_MAX - 1 - sizeof(struct aws_string));
 }

verification/cbmc/stubs/abort_override_assert_false.c

@@ -11,6 +11,6 @@
 
 #include <assert.h>
 
-void abort() {
+void abort(void) {
     assert(0);
 }