Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request response workspace #664

Open
wants to merge 31 commits into
base: main
Choose a base branch
from
Open

Request response workspace #664

Show file tree
Hide file tree
Changes from 17 commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
e73f8c1
Checkpoint
Sep 12, 2024
d4b438a
Checkpoint
bretambrose Sep 16, 2024
5f2268c
Checkpoint
bretambrose Sep 16, 2024
51abfd6
Change signature
bretambrose Sep 18, 2024
aff7650
Install rr headers
bretambrose Sep 18, 2024
fd25b31
Destructors
bretambrose Sep 18, 2024
0e53bfa
Stream creation signature update
bretambrose Sep 18, 2024
3d55010
Stream creation API tweaks
bretambrose Sep 18, 2024
806b069
Remove unused field
bretambrose Sep 18, 2024
dee89a3
Misc updates
bretambrose Sep 19, 2024
2f9d543
Streaming operation reference fixup
bretambrose Sep 19, 2024
b679727
Initial polish
bretambrose Sep 19, 2024
5afe2ff
Don't export-tag templated types
bretambrose Sep 19, 2024
dfdd59a
Constructor fix
bretambrose Sep 19, 2024
22cf10a
Formatting
bretambrose Sep 19, 2024
34353df
Submodule update
bretambrose Sep 19, 2024
d3c20ef
Try and see if this resolves warning
bretambrose Sep 20, 2024
95e1eea
PR Feedback
bretambrose Sep 20, 2024
a9c8780
Check function objects
bretambrose Sep 20, 2024
237498a
Begin testing
bretambrose Sep 20, 2024
6614a37
Checkpoint
Sep 23, 2024
9fffa03
Finish tests
Oct 2, 2024
89ad173
Doc comments
Oct 3, 2024
c2ab65f
Compile error
Oct 3, 2024
78bf79d
More things that should've been picked up locally
Oct 7, 2024
f326120
Log the payload to see why the request was rejected
Oct 7, 2024
e40192f
Log outbound payload
Oct 7, 2024
65e7425
Weird how that ever worked
Oct 7, 2024
75b21e1
Tests were interfering across CI jobs
Oct 7, 2024
58416fb
unreferenced params
Oct 7, 2024
6ff68c5
Merge branch 'main' into RequestResponseWorkspace
bretambrose Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .clang-tidy
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
Checks: 'clang-diagnostic-*,clang-analyzer-*,readability-*,modernize-*,bugprone-*,misc-*,google-runtime-int,llvm-header-guard,fuchsia-restrict-system-includes,-clang-analyzer-valist.Uninitialized,-clang-analyzer-security.insecureAPI.rand,-clang-analyzer-alpha.*,-readability-magic-numbers,-readability-non-const-parameter'
Checks: 'clang-diagnostic-*,clang-analyzer-*,readability-*,modernize-*,bugprone-*,misc-*,google-runtime-int,llvm-header-guard,fuchsia-restrict-system-includes,-clang-analyzer-valist.Uninitialized,-clang-analyzer-security.insecureAPI.rand,-clang-analyzer-alpha.*,-readability-magic-numbers,-readability-non-const-parameter,-modernize-use-trailing-return-type'
WarningsAsErrors: '*'
HeaderFilterRegex: '.*(?<!cJSON.cpp)$'
FormatStyle: 'file'
Expand Down
2 changes: 1 addition & 1 deletion crt/aws-c-mqtt
Open in desktop
Submodule aws-c-mqtt updated 45 files
+12 −3 .github/workflows/ci.yml
+4 −6 .github/workflows/clang-format.yml
+18 −10 CMakeLists.txt
+29 −0 bin/elastishadow/CMakeLists.txt
+1,272 −0 bin/elastishadow/main.c
+47 −0 format-check.py
+0 −24 format-check.sh
+12 −0 include/aws/mqtt/mqtt.h
+54 −0 include/aws/mqtt/private/client_impl.h
+24 −0 include/aws/mqtt/private/client_impl_shared.h
+204 −0 include/aws/mqtt/private/mqtt311_listener.h
+220 −0 include/aws/mqtt/private/request-response/protocol_adapter.h
+23 −0 include/aws/mqtt/private/request-response/request_response_client.h
+264 −0 include/aws/mqtt/private/request-response/subscription_manager.h
+2 −0 include/aws/mqtt/private/shared.h
+274 −0 include/aws/mqtt/request-response/request_response_client.h
+3 −0 include/aws/mqtt/v5/mqtt5_client.h
+176 −58 source/client.c
+6 −0 source/client_channel_handler.c
+9 −0 source/client_impl_shared.c
+34 −0 source/mqtt.c
+329 −0 source/mqtt311_listener.c
+2 −3 source/packets.c
+964 −0 source/request-response/protocol_adapter.c
+2,276 −0 source/request-response/request_response_client.c
+822 −0 source/request-response/subscription_manager.c
+1 −1 source/shared.c
+1 −1 source/v5/mqtt5_client.c
+1 −0 source/v5/mqtt5_listener.c
+14 −0 source/v5/mqtt5_to_mqtt3_adapter.c
+135 −3 tests/CMakeLists.txt
+1,784 −0 tests/request-response/protocol_adapter_tests.c
+3,151 −0 tests/request-response/request_response_client_tests.c
+2,877 −0 tests/request-response/subscription_manager_tests.c
+739 −998 tests/v3/connection_state_test.c
+488 −0 tests/v3/mqtt311_listener_test.c
+582 −0 tests/v3/mqtt311_testing_utils.c
+155 −0 tests/v3/mqtt311_testing_utils.h
+51 −2 tests/v3/mqtt_mock_server_handler.c
+18 −0 tests/v3/mqtt_mock_server_handler.h
+22 −42 tests/v5/mqtt5_client_tests.c
+26 −0 tests/v5/mqtt5_testing_utils.c
+20 −0 tests/v5/mqtt5_testing_utils.h
+0 −4 tests/v5/mqtt5_to_mqtt3_adapter_tests.c
+2 −1 tests/v5/mqtt5_topic_alias_tests.c
1 change: 1 addition & 0 deletions include/aws/crt/Variant.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,6 +404,7 @@ namespace Aws
{
template <typename AlternativeT> void operator()(AlternativeT &&value) const
{
(void)value;
using PlaintT = typename std::remove_reference<AlternativeT>::type;
value.~PlaintT();
}
Expand Down
2 changes: 2 additions & 0 deletions include/aws/crt/mqtt/Mqtt5Client.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,6 +435,8 @@ namespace Aws

virtual ~Mqtt5Client();

struct aws_mqtt5_client *GetUnderlyingHandle() const noexcept;

private:
Mqtt5Client(const Mqtt5ClientOptions &options, Allocator *allocator = ApiAllocator()) noexcept;

Expand Down
2 changes: 1 addition & 1 deletion include/aws/crt/mqtt/MqttConnection.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ namespace Aws
bool Disconnect() noexcept;

/// @private
aws_mqtt_client_connection *GetUnderlyingConnection() noexcept;
aws_mqtt_client_connection *GetUnderlyingConnection() const noexcept;

/**
* Subscribes to topicFilter. OnMessageReceivedHandler will be invoked from an event-loop
Expand Down
2 changes: 2 additions & 0 deletions include/aws/crt/mqtt/private/Mqtt5ClientCore.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,8 @@ namespace Aws

virtual ~Mqtt5ClientCore();

struct aws_mqtt5_client *GetUnderlyingHandle() const noexcept { return m_client; }

private:
Mqtt5ClientCore(const Mqtt5ClientOptions &options, Allocator *allocator = ApiAllocator()) noexcept;

Expand Down
2 changes: 1 addition & 1 deletion include/aws/crt/mqtt/private/MqttConnectionCore.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ namespace Aws
bool Disconnect() noexcept;

/// @private
aws_mqtt_client_connection *GetUnderlyingConnection() noexcept;
aws_mqtt_client_connection *GetUnderlyingConnection() const noexcept;

/**
* @internal
Expand Down
Loading
Loading