Fix STSCredentialsProvider (#301)

awslabs · Dec 3, 2024 · dd17a98 · dd17a98
1 parent 37ab536
commit dd17a98
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 8 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -49,7 +49,6 @@ jobs:
       matrix:
         # This matrix runs tests on Mac, on oldest & newest supported Xcodes
         runner:
-          - macos-12 # x64
           - macos-13 # x64
           - macos-14
           - macos-13-xlarge
@@ -72,7 +71,6 @@ jobs:
       matrix:
         # This matrix runs tests on iOS, tvOS & watchOS, on oldest & newest supported Xcodes
         runner:
-          - macos-12 # x64
           - macos-13 # x64
           - macos-14
           - macos-13-xlarge
@@ -91,8 +89,6 @@ jobs:
           # Don't run old macOS with new Xcode
           - runner: macos-13-xlarge
             xcode: Xcode_15.2
-          - runner: macos-12
-            xcode: Xcode_15.2
           - runner: macos-13
             xcode: Xcode_15.2
           # Don't run new macOS with old Xcode

diff --git a/Source/AwsCommonRuntimeKit/auth/credentials/CredentialsProvider.swift b/Source/AwsCommonRuntimeKit/auth/credentials/CredentialsProvider.swift
@@ -483,6 +483,7 @@ extension CredentialsProvider.Source {
         Self {
             let shutdownCallbackCore = ShutdownCallbackCore(shutdownCallback)
             var stsOptions = aws_credentials_provider_sts_options()
+            stsOptions.bootstrap = bootstrap.rawValue
             stsOptions.tls_ctx = tlsContext.rawValue
             stsOptions.creds_provider = credentialsProvider.rawValue
             stsOptions.duration_seconds = UInt16(duration)

diff --git a/Test/AwsCommonRuntimeKitTests/auth/CredentialsProviderTests.swift b/Test/AwsCommonRuntimeKitTests/auth/CredentialsProviderTests.swift
@@ -221,17 +221,17 @@ class CredentialsProviderTests: XCBaseTestCase {
                 tokenFilePath: "tokenFilePath"))
     }
 
-    func testCreateDestroyStsInvalidRole() async throws {
+    func testCreateDestroySts() async throws {
         let provider = try CredentialsProvider(source: .static(accessKey: accessKey,
                 secret: secret,
                 sessionToken: sessionToken))
-        XCTAssertThrowsError(try CredentialsProvider(source: .sts(bootstrap: getClientBootstrap(),
+        _ = try CredentialsProvider(source: .sts(bootstrap: getClientBootstrap(),
                 tlsContext: getTlsContext(),
                 credentialsProvider: provider,
-                roleArn: "invalid-role-arn",
+                roleArn: "roleArn",
                 sessionName: "test-session",
                 duration: 10,
-                shutdownCallback: getShutdownCallback())))
+                shutdownCallback: getShutdownCallback()))
     }
 
     func testCreateDestroyEcsMissingCreds() async throws {