Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of LambdaFuctionURLRequest/Response #187

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

thomasgouveia
Copy link

Fixes #172

Description of changes:

This PR add the support for AWS Lambda Function URL Request and Response. It was needed to bump the package aws-lambda-go to a more recent version.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

=> I do.

@thomasgouveia thomasgouveia marked this pull request as ready for review June 16, 2023 04:25
@suntong
Copy link

suntong commented Aug 2, 2023

Thanks @thomasgouveia, that's exactly what I was looking for.

Would you add an example of how to make use of the AWS Lambda Function URL in deployment please?

IE, maybe duplicate sam.yaml and change as sam-FuctionURL.yaml, maybe? Thanks!

@suntong
Copy link

suntong commented Aug 2, 2023

IE, maybe duplicate sam.yaml and change as sam-FuctionURL.yaml, maybe? Thanks!

Oh, the API signature has changed as well, so maybe a sample that makes use the FuctionURL API signature entirely (code + deployment), maybe? Thanks!

@dza89
Copy link

dza89 commented Sep 9, 2023

Next time I should check PRs before doing stuff.
@thomasgouveia shall we merge both PRs?
#190

@thomasgouveia
Copy link
Author

Hi @dza89, sure we can. I don't have much time currently to do it, so I can't give you an ETA if I do it. Do you want to work on it?

Hi @suntong, as I said above, I don't have much time currently. I'll try to give you an example ASAP, but I can't commit to an ETA.

@dza89
Copy link

dza89 commented Sep 17, 2023

@thomasgouveia I've added your commit to my PR #190

@sapessi
Copy link
Collaborator

sapessi commented Sep 22, 2023

If you can help resolve the conflicts I will publish this with the next release

@dza89
Copy link

dza89 commented Sep 23, 2023

@sapessi
I've added @thomasgouveia commit into #190 and extended it with support for fiber.

@suntong
Copy link

suntong commented Oct 17, 2023

If you can help resolve the conflicts I will publish this with the next release

@sapessi, I tested @dza89's #190 PR just now and it is working fine for me.

Hope the PR will be merged/published soon. thanks.

@dza89
Copy link

dza89 commented Nov 9, 2023

@sapessi
#190 superseeded by #192

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support of LambdaFuctionURLRequest/Response
4 participants