Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DocumentDB support #706

Merged
merged 27 commits into from
Oct 19, 2023
Merged

Conversation

nichmorgan
Copy link
Contributor

@nichmorgan nichmorgan commented Oct 18, 2023

Issue #, if available:

Description of changes:

DocumentDB event support created.
It was considered that this service only supports mongo events up to version 5. However, as in version 6 there are greater variations of fields in the structs, it was decided to duplicate this initially to facilitate future updates when version 6 is supported.

The supported events and their links are:

In all the structs, the "operation_type" field has been commented out to mention its existence, but it should not be defined in the code because it is only used when deserializing the entry in the "ChangeEvent" enum configured as follows:

#[serde(tag = "operationType", rename_all = "camelCase")]

By submitting this pull request

  • I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I confirm that I've made a best effort attempt to update all relevant documentation.

@nichmorgan nichmorgan mentioned this pull request Oct 18, 2023
@nichmorgan nichmorgan changed the title Feature/documentdb support DocumentDB support Oct 18, 2023
@calavera
Copy link
Contributor

Thanks a lot for opening this PR! I just merged some fixes for tests that were failing and were unrelated to your changes. Can you rebase from the main branch and resolve the conflicts?

Copy link
Contributor

@calavera calavera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@calavera calavera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you rebase from main again? it looks like the eventbridge changes created a conflict. It might be better to put the Makefile changes in alphabetical order to prevent future conflicts like this one.

Copy link
Contributor

@calavera calavera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution! LGTM

@calavera calavera merged commit 2675fa9 into awslabs:main Oct 19, 2023
5 checks passed
@nichmorgan nichmorgan deleted the feature/documentdb-support branch October 19, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants