Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed clippy warnings in lambda-events #910

Merged
merged 1 commit into from
Jul 14, 2024

Conversation

rimutaka
Copy link
Contributor

A minor fix to remove Clippy warnings in lambda-events:

this expression creates a reference which is immediately dereferenced by the compiler
for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
`#[warn(clippy::needless_borrow)]` on by defaultclippy[Click for full compiler diagnostic](rust-analyzer-diagnostics-view:/diagnostic%20message%20%5B0%5D?0#file%3A%2F%2F%2Fhome%2Fmx%2Fprojects%2Fgh-forks%2Faws-lambda-rust-runtime-fork%2Flambda-events%2Fsrc%2Fevent%2Fcloudwatch_events%2Fcloudtrail.rs)
cloudtrail.rs(103, 59): change this to: `output.as_bytes()`

Weirdly enough, the warnings came up in VSCode, but not in the CLI.
@martinjlowm, please take a look if you get a chance in case I'm breaking something with this fix. It was your code.

🔏 By submitting this pull request

  • I confirm that I've ran cargo +nightly fmt.
  • I confirm that I've ran cargo clippy --fix.
  • I confirm that I've made a best effort attempt to update all relevant documentation.
  • I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rimutaka rimutaka marked this pull request as ready for review July 13, 2024 23:47
Copy link
Contributor

@calavera calavera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@calavera calavera merged commit 2708342 into awslabs:main Jul 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants