Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle case where no ECS tasks are returned #146

Merged
merged 1 commit into from
May 31, 2024

Conversation

niallthomson
Copy link
Contributor

@niallthomson niallthomson commented May 31, 2024

Issue # (if applicable)

Related to #140

Reason for this change

When the ECS API returns no tasks it should not display an error, just an empty list

Description of changes

Altered code path to gracefully handle no ECS tasks being returned

Description of how you validated changes

Added unit test for this scenario

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@niallthomson niallthomson requested a review from a team as a code owner May 31, 2024 02:44
@niallthomson niallthomson merged commit b441b78 into main May 31, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant