feat: Observability for RayServe and vLLM GPU #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: Rayserve and vLLM o11y
vara-bonthu
reviewed
Sep 9, 2024
vara-bonthu
reviewed
Sep 15, 2024
Comment on lines
+174
to
+177
| enable_aws_cloudwatch_metrics = true | ||
| aws_cloudwatch_metrics = { | ||
| values = [templatefile("${path.module}/helm-values/aws-cloudwatch-metrics-values.yaml", {})] | ||
| } |
There was a problem hiding this comment.
We should switch to EKS managed add-on for CloudWatch and remove this. Please see the BioNemo PR as an example https://github.com/awslabs/data-on-eks/pull/641/files#diff-0222ef610acbd44e74c858a5505a877ad82439b934b0667e3f81dc91d3a247fdR26
There was a problem hiding this comment.
You can do this in the second PR.
|
Verify pre-commit Min TF check please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR provides observability with Prom and Grafana for rayserve-vllm-gpu pattern
🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.
Motivation
#586
#645
More
website/docsorwebsite/blogsection for this featurepre-commit run -awith this PR. Link for installing pre-commit locallyFor Moderators
Additional Notes