refactor: Update Kafka Blueprint to use more recent versions of Kafka and Strimzi, and use Karpenter #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n to now use Kraft
chrismld
changed the title
|
LGTM! |
ovaleanu
approved these changes
Oct 11, 2024
vara-bonthu
reviewed
Oct 11, 2024
streaming/kafka/providers.tf
Outdated
| # host = module.eks.cluster_endpoint | ||
| # cluster_ca_certificate = base64decode(module.eks.cluster_certificate_authority_data) | ||
| # token = data.aws_eks_cluster_auth.this.token | ||
| config_path = "/Users/chrismld/.kube/config" |
There was a problem hiding this comment.
remove this config path
streaming/kafka/providers.tf
Outdated
| # host = module.eks.cluster_endpoint | ||
| # cluster_ca_certificate = base64decode(module.eks.cluster_certificate_authority_data) | ||
| # token = data.aws_eks_cluster_auth.this.token | ||
| config_path = "/Users/chrismld/.kube/config" |
streaming/kafka/eks.tf
Outdated
| desired_size = 3 | ||
|
|
||
| instance_types = ["m6g.xlarge", "m6gd.xlarge", "m7g.xlarge", "c6g.xlarge", "c6gd.xlarge", "c7g.xlarge"] | ||
| ami_type = "AL2_ARM_64" |
There was a problem hiding this comment.
Change this to ami_type = "AL2023_ARM_64_STANDARD"
vara-bonthu
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Solves the issue #596 by updating the Kafka blueprint to use most recent versions of Kafka, Strimzi, and it's now using Karpenter.
Motivation
I have a customer that migrated to Karpenter using the latest versions of Kafka and Strimzi, and I wanted to keep this blueprint up to date as other customers are looking for guidance.
More
website/docsorwebsite/blogsection for this featurepre-commit run -awith this PR. Link for installing pre-commit locallyFor Moderators
Additional Notes