Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Spark-operator update karpenter to v1 #673

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat: Spark-operator update karpenter to v1 #673

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ac47f30
update karpenter chart to 1.0.0
alanty Oct 10, 2024
c86ee2b
bump karpenter to 1.0.0
alanty Oct 10, 2024
65512d9
fix install script
alanty Oct 10, 2024
3725b88
bump data addons to match karpenter v1 minimum
alanty Oct 11, 2024
c9a85c3
ping data addons version to 1.34.0, karpenter to 1.0.6
alanty Oct 11, 2024
a660415
Merge remote-tracking branch 'origin/main' into spark-karpenter-v1
alanty Oct 14, 2024
36bebbc
pre-commit cleanup
alanty Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion analytics/terraform/spark-eks-ipv6/addons.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ module "eks_blueprints_addons" {
}
}
karpenter = {
chart_version = "0.37.0"
chart_version = "1.0.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might need to uplift data addons tag and update the Karpenter resources to v1.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call. I was pulling v1.34.0 but we should set that as the min.

When i rolled this out the existing karpenter resource configs seemed to get created as v1 but i'm still working through the configs to see if they need updates to the spec.

repository_username = data.aws_ecrpublic_authorization_token.token.user_name
repository_password = data.aws_ecrpublic_authorization_token.token.password
}
Expand Down
1 change: 0 additions & 1 deletion analytics/terraform/spark-eks-ipv6/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
#!/bin/bash

read -p "Enter the region: " region
read -p "
export AWS_DEFAULT_REGION=$region

# List of Terraform modules to apply in sequence
Expand Down
4 changes: 2 additions & 2 deletions analytics/terraform/spark-k8s-operator/addons.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
#---------------------------------------------------------------
module "eks_data_addons" {
source = "aws-ia/eks-data-addons/aws"
version = "~> 1.30" # ensure to update this to the latest/desired version
version = "~> 1.34" # ensure to update this to the latest/desired version
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use a fixed version instead, in this case it should be 1.34.0 ... we just had a problem because of the ~> config

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I was able to merge all the upstream changes and keep the versions you mention here (Addons 1.34.0 and karpenter 1.0.6).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, this LGTM!


oidc_provider_arn = module.eks.oidc_provider_arn

Expand Down Expand Up @@ -417,7 +417,7 @@ module "eks_blueprints_addons" {
}
}
karpenter = {
chart_version = "v0.34.0"
chart_version = "1.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use the latest version 1.0.6

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I was able to merge all the upstream changes and keep the versions you mention here (Addons 1.34.0 and karpenter 1.0.6).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, this LGTM!

repository_username = data.aws_ecrpublic_authorization_token.token.user_name
repository_password = data.aws_ecrpublic_authorization_token.token.password
}
Expand Down
Loading