specify path to the spec files #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toidiu
force-pushed
the
ak-spec_path
branch
from
8cf0c23
to
9c93f00
Compare
toidiu
force-pushed
the
ak-spec_path
branch
from
f380ddf
to
f97c789
Compare
toidiu
commented
Sep 25, 2023
toidiu
commented
Sep 25, 2023
camshaft
reviewed
Sep 25, 2023
src/target.rs
Outdated
| @@ -72,10 +72,10 @@ impl TargetPath { | |||
| Ok(Self::Path(path)) | |||
| } | |||
|
|
|||
| pub fn load(&self) -> Result<String, Error> { | |||
| pub fn load(&self, spec_download_path: Option<&String>) -> Result<String, Error> { | |||
There was a problem hiding this comment.
Suggested change
| pub fn load(&self, spec_download_path: Option<&String>) -> Result<String, Error> { | |
| pub fn load(&self, spec_path: Option<&str>) -> Result<String, Error> { |
camshaft
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aws/s2n-tls#4219
Description of changes:
Duvet was originally designed so that the spec files would be stored at project root. Since, ends up cluttering the codebase, some projects such as s2n-tls instead store all spec related material in a separate directory. This results in unexpected behavior where the
reportcommand is unable to find the spec files and attempts to re-download them each time.This PR expose a new argument
--spec-download-pathwhich can be used to specify the location where to download the spec files. Specifically for s2n-tls you could add--spec-download-path 'compliance'to the generate script.Callout
I only exposed the spec-download-path for the
reportsub-command and notextractsince it possible to run extract from any directory. We can always add this param if we want later on.Testing
I tested this locally to confirm that this works with the directory structure in s2n-tls.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.