feat: Initialized projen and added project structure for cdk constructs #1
Conversation
.projenrc.ts
Outdated
| // Constants | ||
| const CDK_VERSION: string = '2.93.0'; | ||
| const DEFAULT_RELEASE_BRANCH: string = 'main'; | ||
| const AUTHOR_EMAIL: string = '[email protected]'; |
There was a problem hiding this comment.
This goes nowhere, for now let's use [email protected]
.projenrc.ts
Outdated
| const DEFAULT_RELEASE_BRANCH: string = 'main'; | ||
| const AUTHOR_EMAIL: string = '[email protected]'; | ||
| const AUTHOR_NAME: string = 'Amazon Web Services'; | ||
| //const NODE_VERSION: string = '20.5.1'; |
There was a problem hiding this comment.
Might we consider 18.x until 20.x becomes "Active" https://github.com/nodejs/release#release-schedule?
There was a problem hiding this comment.
changed node version to 18.17.1
.projenrc.ts
Outdated
| author: AUTHOR_NAME, | ||
| authorAddress: AUTHOR_EMAIL, | ||
| cdkVersion: CDK_VERSION, | ||
| //minNodeVersion: NODE_VERSION, |
There was a problem hiding this comment.
Consider 16.20.2 since this in "Maintenance" until 2023-10-26
There was a problem hiding this comment.
changed node version to 18.17.1, using it as min version.
DEVELOPER_GUIDE.md
Outdated
| Default output format [None]: json | ||
| ``` | ||
|
|
||
| - Node.js: v20.5.1 |
There was a problem hiding this comment.
wasn't this v18.17.1 until LTS for v20?
There was a problem hiding this comment.
changed node version to 18.17.1
|
|
||
| ## Security |
There was a problem hiding this comment.
Add the section back.
|
|
||
| ## License |
There was a problem hiding this comment.
Good to leave the License information in.
There was a problem hiding this comment.
added it back.
ghost
merged commit 
chore(documentation): add api
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.