Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(construct): pin version of lambda base python image #101

Merged
merged 3 commits into from
Nov 16, 2023

Conversation

krokoko
Copy link
Collaborator

@krokoko krokoko commented Nov 16, 2023

Fixes #

https://aws.amazon.com/blogs/compute/introducing-the-amazon-linux-2023-runtime-for-aws-lambda/
Pin version of the lambda base image used to avoid failure due to recent changes
image

tested by locally building one of the images, doesn't fail anymore


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.

@krokoko krokoko requested a review from a team as a code owner November 16, 2023 00:30
@krokoko krokoko changed the title feat(construct): pin version of lambda python due to recent changes feat(construct): pin version of lambda base python image Nov 16, 2023
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (31065b5) 93.54% compared to head (438912e) 93.54%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #101   +/-   ##
=======================================
  Coverage   93.54%   93.54%           
=======================================
  Files          16       16           
  Lines        4599     4599           
  Branches      108      108           
=======================================
  Hits         4302     4302           
  Misses        297      297           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@justintlewis justintlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krokoko krokoko merged commit af41792 into main Nov 16, 2023
12 checks passed
@krokoko krokoko deleted the feat/docker_lambda_images branch November 16, 2023 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants