feat: added common helpers like redis,appsyncmergeapi,event bridge an… #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 3, 2023 22:16
…d updated vpc helper
…d updated vpc helper
krokoko
requested changes
Oct 4, 2023
src/patterns/gen-ai/aws-summarization-appsync-stepfn/summary_architecture.gif
Outdated
Show resolved
Hide resolved
krokoko
previously approved these changes
Oct 5, 2023
src/patterns/gen-ai/aws-summarization-appsync-stepfn/architecture.png
Outdated
Show resolved
Hide resolved
laithalsaadoon
previously approved these changes
Oct 5, 2023
| } | ||
|
|
||
| function getMergedAPIRole(scope: Construct, props: AppsyncMergedApiProps) { | ||
| return new iam.Role(scope, 'mergedapirole', { |
There was a problem hiding this comment.
A small nit pick, can we use camel case for resource names?
| * @param AppsyncMergedApiProps The props to be used by the construct | ||
| * @returns App sync merge api | ||
| */ | ||
| export function buildMergedAPI(scope: Construct, props: AppsyncMergedApiProps, logProps: LogConfigProps) { |
There was a problem hiding this comment.
Is it a common convention to have two prop arguments? consider one Prop with a key-value of type LogConfigProps
| import { Construct } from 'constructs'; | ||
|
|
||
|
|
||
| export interface AppsyncMergedApiProps { |
There was a problem hiding this comment.
Can some of these be strongly typed? then perhaps getting the ID's from the object properties later in the code (foo.cognitoUserPoolId)
| const redisclustername = props.redisclustername || 'redisCluster'; | ||
| const cacheNodeType = props.cacheNodeType || 'cache.r6g.xlarge'; | ||
|
|
||
| let redisCulster = new elasticache.CfnCacheCluster(scope, 'redisCluster', { |
There was a problem hiding this comment.
This is great! love the way you used the local functions here
scottschreckengaust
requested changes
Oct 5, 2023
Removed package-lock.json from the PR. Managed by projen but need to review it again to make sure there is only one package manager. Signed-off-by: Dinesh Sajwan <[email protected]>
dineshSajwan
dismissed stale reviews from laithalsaadoon and krokoko
via
9a53381
scottschreckengaust
approved these changes
Oct 5, 2023
krokoko
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Added following common/helpers construct.
# redis-helper.ts,
# appsyncmergedapi-helper.
# eventbridge-helper.ts
# updated vpc-helper.ts
Added Pattern aws-summarization-appsync-stepfn
# Initial Readme draft for summarization pattern construct.
# Architecture diagram.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.