feat(documentation): Update documentation and standardize #41
Conversation
Codecov ReportAll modified lines are covered by tests ✅
📢 Thoughts on this report? Let us know!. |
| @@ -32,9 +58,57 @@ import { Construct } from 'constructs'; | |||
| import { Stack, StackProps } from 'aws-cdk-lib'; | |||
| import { SummarizationAppsyncStepfn, SummarizationAppsyncStepfnProps } from '@aws-samples/aws-emerging-tech-constructs'; | |||
|
|
|||
There was a problem hiding this comment.
import * as cognito from 'aws-cdk-lib/aws-cognito';
There was a problem hiding this comment.
good catch, fixed in 235ae22
| - [AWS Secrets Manager Pricing](https://aws.amazon.com/secrets-manager/pricing/) | ||
|
|
||
| > **Note** | ||
| >You can share the Amazon OpenSearch provisioned cluster between use cases, but this can drive up the number of queries per index and additional charge will apply. |
There was a problem hiding this comment.
we should add the same warnings which are present in common-layer readme file for data security with external LLM.
There was a problem hiding this comment.
for now the other constructs are using Bedrock only (cannot be changed). When those constructs will be updated to use the lambda layer, it will give the ability to the user to use any supported LLM. At that moment I will add the warning message : )
|
|
||
| ``` | ||
| mutation MyMutation { | ||
| generateSummary(summaryInput:{files:[{name: "document1.txt", status: ""}], summary_job_id:"81"}) { |
There was a problem hiding this comment.
Did you updated the summary document reader lambda to support input file with txt format. don't see lambda change in this PR. The current input validator lambda expect pdf file and then the document reader lambda update the file format to txt based on isFileTransformationRequired flag.
There was a problem hiding this comment.
next PR I will fix it for both qa and summarization
There was a problem hiding this comment.
Very detailed documentation. really liked it.
Fixes #
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.