feat(constructs): bug fixes from joyride testing #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
📢 Thoughts on this report? Let us know!. |
hvital
approved these changes
Oct 25, 2023
| logger.info(f"_retriever={handler_type} does not match _current_retriever={_current_doc_index}, " | ||
| f"resetting retriever") | ||
| _doc_index = None | ||
|
|
||
| if _doc_index is None: |
There was a problem hiding this comment.
when will be _doc_index not null
There was a problem hiding this comment.
statically initialized before the method signature
| requests==2.31.0 | ||
| requests-aws4auth==1.2.3 | ||
| opensearch-py==2.3.1 | ||
| numpy |
There was a problem hiding this comment.
are we using numpy, couldn't find any import for this.
| ) | ||
| sts_client = boto3.client("sts") | ||
|
|
||
| def get_bedrock_client(service_name="bedrock-runtime"): |
There was a problem hiding this comment.
can't this function be imported from opensearch_helper.py
dineshSajwan
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Fixes multiple issues related to testing of the constructs:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.