-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(release): public release to npm #97
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #97 +/- ##
=======================================
Coverage 93.54% 93.54%
=======================================
Files 16 16
Lines 4599 4599
Branches 108 108
=======================================
Hits 4302 4302
Misses 297 297 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix for Pypi
.projenrc.ts
Outdated
distName: PROJECT_NAME, | ||
module: PROJECT_NAME.replace(/-/g, '_'), // PEP 8, convert hypens | ||
distName: PUBLICATION_NAMESPACE+'.'+PROJECT_NAME, | ||
module: PUBLICATION_NAMESPACE+'.'+(PROJECT_NAME.replace(/-/g, '_')), // PEP 8, convert hypens |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
module: PUBLICATION_NAMESPACE+'.'+(PROJECT_NAME.replace(/-/g, '_')), // PEP 8, convert hypens | |
module: (PUBLICATION_NAMESPACE.replace(/-/g, '_'))+'.'+(PROJECT_NAME.replace(/-/g, '_')), // PEP 8, convert hypens |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
protect against hypen, -
.
Signed-off-by: github-actions <[email protected]>
Fixes #
update configuration for publication to npm
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.