Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(release): public release to npm #97

Merged
merged 14 commits into from
Nov 15, 2023
Merged

feat(release): public release to npm #97

merged 14 commits into from
Nov 15, 2023

Conversation

krokoko
Copy link
Collaborator

@krokoko krokoko commented Nov 15, 2023

Fixes #

update configuration for publication to npm


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (62b60cd) 93.54% compared to head (e09618c) 93.54%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #97   +/-   ##
=======================================
  Coverage   93.54%   93.54%           
=======================================
  Files          16       16           
  Lines        4599     4599           
  Branches      108      108           
=======================================
  Hits         4302     4302           
  Misses        297      297           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@scottschreckengaust scottschreckengaust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix for Pypi

@krokoko krokoko requested a review from mrgrain November 15, 2023 16:41
.projenrc.ts Outdated
distName: PROJECT_NAME,
module: PROJECT_NAME.replace(/-/g, '_'), // PEP 8, convert hypens
distName: PUBLICATION_NAMESPACE+'.'+PROJECT_NAME,
module: PUBLICATION_NAMESPACE+'.'+(PROJECT_NAME.replace(/-/g, '_')), // PEP 8, convert hypens
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
module: PUBLICATION_NAMESPACE+'.'+(PROJECT_NAME.replace(/-/g, '_')), // PEP 8, convert hypens
module: (PUBLICATION_NAMESPACE.replace(/-/g, '_'))+'.'+(PROJECT_NAME.replace(/-/g, '_')), // PEP 8, convert hypens

Copy link
Collaborator

@scottschreckengaust scottschreckengaust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

protect against hypen, -.

Signed-off-by: github-actions <[email protected]>
@krokoko krokoko merged commit 4399f48 into main Nov 15, 2023
10 checks passed
@krokoko krokoko deleted the feature/public_release branch November 15, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants