Expose function to enable debug logging #108
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnanuti
had a problem deploying
to
integration-tests
GitHub Actions
Failure
dnanuti
had a problem deploying
to
integration-tests
GitHub Actions
Failure
dnanuti
had a problem deploying
to
integration-tests
GitHub Actions
Failure
dnanuti
had a problem deploying
to
integration-tests
GitHub Actions
Failure
dnanuti
had a problem deploying
to
integration-tests
GitHub Actions
Failure
dnanuti
had a problem deploying
to
integration-tests
GitHub Actions
Failure
dnanuti
had a problem deploying
to
integration-tests
GitHub Actions
Failure
dnanuti
had a problem deploying
to
integration-tests
GitHub Actions
Failure
dnanuti
commented
Jan 18, 2024
| @@ -1,6 +1,6 @@ | |||
| # Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | |||
| # // SPDX-License-Identifier: BSD | |||
| from s3torchconnectorclient import S3Exception | |||
| from s3torchconnectorclient import S3Exception, enable_debug_logging | |||
There was a problem hiding this comment.
Thinking out loud - perhaps we also need a wrapper on the Python side of things that takes in a logging config and a log level and configures the logging module like below, but with the passed in parameters:
logging.basicConfig(
format="%(levelname)s %(name)s %(asctime)-15s %(filename)s:%(lineno)d %(message)s"
)
logging.getLogger().setLevel(LOG_TRACE)
Draft function to enable CRT logs for debug purposes
dnanuti
force-pushed
the
debug-logging
branch
from
fde1c3f
to
7f6d5cc
Compare
dnanuti
had a problem deploying
to
integration-tests
GitHub Actions
Error
dnanuti
had a problem deploying
to
integration-tests
GitHub Actions
Error
dnanuti
had a problem deploying
to
integration-tests
GitHub Actions
Error
dnanuti
had a problem deploying
to
integration-tests
GitHub Actions
Error
dnanuti
had a problem deploying
to
integration-tests
GitHub Actions
Error
dnanuti
had a problem deploying
to
integration-tests
GitHub Actions
Error
dnanuti
had a problem deploying
to
integration-tests
GitHub Actions
Error
dnanuti
had a problem deploying
to
integration-tests
GitHub Actions
Error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft function to enable CRT logs for debug purposes
Description
We need a user friendly way to enable logs for debugging purposes. This is a rough method to do this.
Additional context
Related items
Testing
By submitting this pull request, I confirm that my contribution is made under the terms of BSD 3-Clause License and I agree to the terms of the LICENSE.