Update mountpoint-s3-client to fix libgit2-sys security issue #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muddyfish
had a problem deploying
to
integration-tests
GitHub Actions
Failure
muddyfish
had a problem deploying
to
integration-tests
GitHub Actions
Failure
muddyfish
had a problem deploying
to
integration-tests
GitHub Actions
Failure
muddyfish
had a problem deploying
to
integration-tests
GitHub Actions
Failure
muddyfish
had a problem deploying
to
integration-tests
GitHub Actions
Failure
muddyfish
had a problem deploying
to
integration-tests
GitHub Actions
Failure
muddyfish
had a problem deploying
to
integration-tests
GitHub Actions
Failure
muddyfish
had a problem deploying
to
integration-tests
GitHub Actions
Failure
muddyfish
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
muddyfish
had a problem deploying
to
integration-tests
GitHub Actions
Failure
muddyfish
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
muddyfish
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
muddyfish
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
muddyfish
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
muddyfish
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
muddyfish
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
muddyfish
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
muddyfish
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
muddyfish
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
muddyfish
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
muddyfish
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
muddyfish
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
muddyfish
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
muddyfish
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
dnanuti
approved these changes
Feb 13, 2024
dnanuti
pushed a commit
that referenced
this pull request
Feb 13, 2024
* Update mountpoint-s3-client to fix libgit2-sys security issue https://rustsec.org/advisories/RUSTSEC-2024-0013 * Update rust-checks to use brand new `manifest-path` input variable --------- Co-authored-by: Simon Beal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previous PRs are blocked on Rust's cargo deny failing: https://github.com/awslabs/s3-connector-for-pytorch/actions/runs/7867873103/job/21464194689?pr=138
These failures are unrelated to their content changes, but instead are due to a new security issue found in
libgit2-sys.https://rustsec.org/advisories/RUSTSEC-2024-0013
This library is being pulled in by our
builtdependency for automatically including versioning information into the release. Mountpoint also used this library, pulling in an earlier version than we were wanting. This PR pulls in an updated Mountpoint version with a more recent dependency onbuilt.Additional context
No breaking changes
Related items
Testing
cargo deny checkpassescargo test --no-default-featurespassespytestpassesBy submitting this pull request, I confirm that my contribution is made under the terms of BSD 3-Clause License and I agree to the terms of the LICENSE.