Migrated actions/download-artifact and actions/upload-artifact from v3 to v4. #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajdchak
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
rajdchak
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
rajdchak
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
rajdchak
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
rajdchak
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
rajdchak
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
rajdchak
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
rajdchak
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
rajdchak
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
rajdchak
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
rajdchak
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
rajdchak
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
rajdchak
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
rajdchak
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
rajdchak
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
rajdchak
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
rajdchak
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
rajdchak
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
rajdchak
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
rajdchak
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
IsaevIlya
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrated actions/download-artifact and actions/upload-artifact from v3 to v4.
In v3, artifacts are mutable so it's possible to write workflow scenarios where multiple jobs upload to the same artifact. In v4, artifacts are immutable (unless deleted). So each of the uploaded artifacts must have a different name. Added mitigation for the same in this PR.
Added a new job in wheels.yml to merge all the wheels generated by the jobs.
Additional context
https://github.com/actions/download-artifact/blob/main/docs/MIGRATION.md
Related items
#209
Testing
Ran all unit and integration tests. Also generated wheels and checked https://github.com/awslabs/s3-connector-for-pytorch/actions/runs/10923188484.
By submitting this pull request, I confirm that my contribution is made under the terms of BSD 3-Clause License and I agree to the terms of the LICENSE.