MDTT-38: Fix for CI failure.

.github/workflows/tests.yml

@@ -33,7 +33,7 @@ jobs:
         run: composer install --no-progress --no-suggest --prefer-dist --optimize-autoloader
 
       - name: Security check installed dependencies
-        uses: symfonycorp/security-checker-action@v2
+        uses: symfonycorp/security-checker-action@v4
 
       - name: Check PSR2 code style (PHP_CodeSniffer)
         run: composer php-cs
@@ -47,4 +47,4 @@ jobs:
       - name: Send code coverage report to Codecov.io
         uses: codecov/codecov-action@v2
         with:
-          token: ${{ secrets.CODECOV_TOKEN }}
+          token: ${{ secrets.CODECOV_TOKEN }}

src/Test/DefaultTest.php

@@ -9,35 +9,34 @@
 
 class DefaultTest extends Test
 {
-
     /**
      * @inheritDoc
      */
     public function execute(array $sourceData, array $destinationData): bool
     {
         $sourceFields = explode('/', $this->getSourceField());
         $destinationFields = explode('/', $this->getDestinationField());
 
         if (!$this->issetField($sourceData, $sourceFields)) {
             throw new ExecutionException("Source field could not be found in the source data.");
         }
 
         if (!$this->issetField($destinationData, $destinationFields)) {
             throw new ExecutionException("Destination field could not be found in the destination data.");
         }
 
         /** @var string|int $sourceValue */
         $sourceValue = array_reduce(
             $sourceFields,
             static fn (array $carry, string $key) => $carry[$key],
             $sourceData
         );
         /** @var string|int $destinationValue */
         $destinationValue = array_reduce(
             $destinationFields,
             static fn (array $carry, string $key) => $carry[$key],
             $destinationData
         );
 
         if ($this->getTransform() !== null) {
             $sourceValue = $this->getTransform()->process($sourceValue);
@@ -46,27 +45,52 @@
         Assert::assertSame(
             $sourceValue,
             $destinationValue,
             sprintf("Source: `%s`\nDestination: `%s`", $sourceValue, $destinationValue)
         );
 
         return true;
     }
 
     /**
-     * @param  array<string, numeric-string|array<string, numeric-string>>|numeric-string  $data
-     * @param  array<string>  $fields
+     * Recursively checks if an offset exists in a nested array.
+     *
+     * This function is designed to handle nested arrays and verify the existence of
+     * a specified offset (string key) within them. It performs recursive checks on
+     * nested arrays to ensure that the offset exists at each level.
+     *
+     * @param array<string, numeric-string|array<string, numeric-string>>|numeric-string $data
+     *     The data array to check for the offset in.
+     * @param array<string> $fields
+     *     An array of string keys representing the path to the desired offset.
      *
      * @return bool
+     *     Returns `true` if the specified offset exists in the nested array,
+     *     `false` otherwise.
+     *
+     * Used a combination of type hinting and explicit checks to assist PHPStan
+     * in understanding the types involved and resolving static analysis errors.
      */
     private function issetField(mixed $data, array $fields): bool
     {
+        // Check if $data is an array
+        if (!is_array($data)) {
+            return false;
+        }
+
+        // Get the next key to check
         $key = array_shift($fields);
+
+        // If there are no more keys to check, the offset exists
         if ($key === null) {
             return true;
         }
 
-        $test = isset($data[$key]);
+        // Check if the key exists in the data array
+        if (!array_key_exists($key, $data)) {
+            return false;
+        }
 
-        return $test && $this->issetField($data[$key], $fields);
+        // Recursively check the next level
+        return $this->issetField($data[$key], $fields);
     }
 }