-
-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.x draft (for ci check only) #2204
base: dev
Are you sure you want to change the base?
Conversation
b28015d
to
d514187
Compare
9a31e45
to
95147ee
Compare
From outside it would be easier to track changes being made to |
currently, 3.x is a draft branch or you can consider it is a temp branch, I don't like make PR one by one to waste much time. I create this PR is only for non-win32 platform ci-check, because I'm compile and test on my windows computer. |
630f361
to
4176cc4
Compare
Physics should be an own test project like fairgui. |
I think physics test in cpp-tests is ok |
df9a625
to
eae98df
Compare
87f50d3
to
894840a
Compare
@halx99
Assertion failed! I getting this also on other tests when I switched drawOrder: to 'true' |
Tested, works well, and no assertion |
On my machine, release build, both 2.2 & 3.0 is 60fps |
Your machine is faster. You cant see this behavior. You have switch the drawOrder =>true (on the both release biulds)? |
I also saw the crazy drawing |
You have switch the drawOrder =>true (on the both release biulds)? |
the ax::Color same with Color4F must be normalized |
|
The ax::Color is just renamed from ax::Color4F, I don't understand what do mean no alpha working |
@halx99 An |
Given that this is a work in progress, it may be a little premature to be attempting to make use of it for any reason. Perhaps wait till it is out of draft and ready for testing. |
I already add .fs .vs as glslcc shader file extension: https://github.com/axmolengine/axmol/blob/3.x/cmake/Modules/AXGLSLCC.cmake#L12 so I don't know why you meet the issue, maybe delete build folder, then re-cmake will fix your issue |
Works now: I download and rebuild axmol again. |
@rh101 The only alpha status will be the internal physics, but this is not using be me at the moment. Thats my opinium. Edit: |
@halx99 |
Why was vertex color changed from bytes to floats? This increases vertex size from 24 bytes to 36 by a 50%! Which will increase memory usage and traffic for no gain and at a performance cost, especially on mobile devices. |
Describe your changes
cpp-tests
works on box2d v3cpp-tests
works on box2d v3core/physics
based on chipmunkcpp-tests
cpp-tests
ax::Color
Issue ticket number and link
Checklist before requesting a review
For each PR
Add Copyright if it missed:
-
"Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."
I have performed a self-review of my code.
Optional:
For core/new feature PR