Skip to content

Commit

Permalink
decrease area tolerance in tests
Browse files Browse the repository at this point in the history
  • Loading branch information
@axsk
axsk committed Oct 31, 2023
1 parent a208adb commit 25fc6af
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/benchmark.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ jobs:
# Use personal access token instead of GITHUB_TOKEN due to https://github.community/t/github-action-not-triggering-gh-pages-upon-push/16096
github-token: ${{ secrets.GITHUB_TOKEN }}
external-data-json-path: ./cache/benchmark-data.json
fail-on-alert: true
fail-on-alert: false
comment-always: true
# Show alert with commit comment on detecting possible performance regression
alert-threshold: '120%'
Expand Down
2 changes: 1 addition & 1 deletion test/runtests.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ smalldata = [rand(2, 1000), rand(3, 1000), rand(4,100)]
small = A .< 1
#println("comparing areas on $(sum(small)) out of $(length(small)) cells")

@test ≈(A[small], area[small], rtol=1e-8)
@test ≈(A[small], area[small], rtol=1e-6)
end

@testset "Monte Carlo Volumes" begin
Expand Down

2 comments on commit 25fc6af

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Julia benchmark result

Benchmark suite Current: 25fc6af Previous: e4b0fac Ratio
2/100 831108 ns 368703 ns 2.25
2/1000 10338793 ns 3704629 ns 2.79
3/100 2953024 ns 1155710 ns 2.56
3/1000 43773153 ns 17058748 ns 2.57
4/100 11771299 ns 4754437 ns 2.48
4/1000 253169687 ns 113580391 ns 2.23
5/100 49559717.5 ns 20699776 ns 2.39
5/1000 1625272222 ns 823220794 ns 1.97

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Julia benchmark result'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: 25fc6af Previous: e4b0fac Ratio
2/100 831108 ns 368703 ns 2.25
2/1000 10338793 ns 3704629 ns 2.79
3/100 2953024 ns 1155710 ns 2.56
3/1000 43773153 ns 17058748 ns 2.57
4/100 11771299 ns 4754437 ns 2.48
4/1000 253169687 ns 113580391 ns 2.23
5/100 49559717.5 ns 20699776 ns 2.39
5/1000 1625272222 ns 823220794 ns 1.97

This comment was automatically generated by workflow using github-action-benchmark.

CC: @axsk

Please sign in to comment.