Skip to content

Commit

Permalink
modify workflow
Browse files Browse the repository at this point in the history
Signed-off-by: a3hadi <[email protected]>
  • Loading branch information
ayildirim21 committed Mar 11, 2024
1 parent 3b6424a commit 48847a6
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 7 deletions.
13 changes: 7 additions & 6 deletions .github/workflows/build-push.yaml
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
name: Docker Publish

on:
pull_request
# types:
# - closed
push:
branches: [ main ]
tags:
- '*'

jobs:
if_merged:
Expand All @@ -16,9 +17,9 @@ jobs:
repository: [
"map-even-odd"
"map-flatmap", "map-forward-message", "map-retry", "map-tickgen"
# "map-flatmap-stream", "reduce-counter", "reduce-sum", "reduce-stream-counter",
# "reduce-stream-sum", "session-counter", "sideinput-example", "udf-sideinput-example",
# "sink-log", "source-simple-source", "mapt-assign-event-time", "mapt-event-time-filter"
"map-flatmap-stream", "reduce-counter", "reduce-sum", "reduce-stream-counter",
"reduce-stream-sum", "session-counter", "sideinput-example", "udf-sideinput-example",
"sink-log", "source-simple-source", "mapt-assign-event-time", "mapt-event-time-filter"
]

steps:
Expand Down
2 changes: 1 addition & 1 deletion development.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ Simply make your changes, build and push the desired example image, and you are
### Deploying

1. Create a PR for your changes. Once merged, it will trigger a workflow to build and push the images for all the examples,
with the tag `stable`. This consistent tag name is used so that the tags in the E2E test pipelines do not need to be
with the tag `stable`. This consistent tag name is used so that the tags in the [E2E test pipelines](https://github.com/numaproj/numaflow/tree/main/test) do not need to be
updated each time a new change is made.
2. After the changes have been merged it is encouraged to update the dependency management files so that the version
displayed in the `go.mod` file reflects the commit SHA of the merged changes. This can be done simply by getting the
Expand Down

0 comments on commit 48847a6

Please sign in to comment.