Add None option to Destinations layer picker #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fix for this is awkward. In order to not mess up the order in which the layer groups draw in the picker, we have to ensure that we add the "None" layer immediately before the remaining destinations layers. The group layer control doesn't give us a way to specify a particular order. If we only add based on whether the ctl.destinationsNoneLayer exists or not, we create it too early during the first scope resolution, and the Destinations draw before the Overlays. If we just create based on whether layers are present in the $q.all callback, we may double create the none layer. Opened: ismyrnow/leaflet-groupedlayercontrol#54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add a "None" layer option to the Destinations layer group so that a user can toggle the display of destinations. This option is selected by default.
Demo
Notes
So that we do not mess up the order in which the layer groups draw in the picker, we have to ensure that we add the "None" layer immediately before the remaining destinations layers. The group layer control doesn't give us a way to specify a particular order.
Opened:
ismyrnow/leaflet-groupedlayercontrol#54
Testing Instructions
Closes #542