Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example code for each configuration to verify correctness during continuous integration #12

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/pullRequestWorkflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,4 @@ jobs:
# Task execution
- run: npm run validate:formatting
- run: npm run validate:linting:eslint
- run: npm run test
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Changelog

## 1.2.0

- Testing added using example code for each configuration to verify correctness during continuous integration
- React and Preact TypeScript configs now allow JSX in files with `.tsx` file extensions
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This improvement resulted from writing the tests

- Remove dev dependency `npm-run-all` because it was only used during the `reinstall` NPM script and would cause an error if dependencies weren't installed prior to execution

## 1.1.0

- Minimum `peerDependencies` ESLint version raised to `8.4.4` to remain compatible with `eslint-plugin-regexp` [version 2.0](https://github.com/ota-meshi/eslint-plugin-regexp/pull/558)+ and the regular expression `v` flag
Expand Down
5 changes: 4 additions & 1 deletion config/eslint/eslintConfig.json
Original file line number Diff line number Diff line change
@@ -1 +1,4 @@
{ "extends": "./lib/eslintNodeConfig.json" }
{
"root": true,
"extends": "./lib/eslintNodeConfig.json"
}
2 changes: 1 addition & 1 deletion config/prettier/prettierConfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@

"overrides": [
{
"files": "*.{cjs,js,jsx,mjs,ts,tsx}",
"files": "*.{cjs,cts,js,jsx,mjs,mts,ts,tsx}",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was originally using .mts files when I started this work. I started off using Bun to write unit tests then settled on using example code and running ESLint against it because it was more informative and easier to identify the root cause of errors.

"options": {
"singleQuote": true
}
Expand Down
11 changes: 0 additions & 11 deletions config/vscode/vscodeProjectConfig.json

This file was deleted.

1 change: 0 additions & 1 deletion jsconfig.json

This file was deleted.

4 changes: 3 additions & 1 deletion lib/eslintReactTypescriptConfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,7 @@
"browser": false,
"node": false
},
"rules": {}
"rules": {
"react/jsx-filename-extension": ["error", { "extensions": [".jsx", ".tsx"] }]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the improvement to the library that resulted from testing. The Preact Typescript config extends this config so it benefits from this too.

}
}
Loading