Prevent False Positives in CI #4642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wdbaruni
requested changes
Oct 23, 2024
wdbaruni
approved these changes
Oct 23, 2024
Utilize ALpine Linux and BusyBox when and where possible Linear Issue: https://linear.app/expanso/issue/ENG-282/prevent-false-positives-in-ci Github Issue: #4635
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since all of our CI scripts are run with BASH, we need to make sure that any unexpected non zero exit code instruction in the script should fail the CI run.
We need to add the snippet below to all our CI scripts:
Note: After this change the lint tests are red, which is good, since they were failing before but the test was passing. There is an already created issue for that: #4605