improve routing of webui requests #4645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have the webui server act as a reverse proxy and route requests to the orchestrator instead of the frontend directly calling the orchestrator. This will simplify webui setup instead of having to define the
WebUI.Backendto the orchestrator's public ip with bacalhau serveThe configuration
WebUI.Backendis still available and make accepting endpoints more gracefulTesting done:
Mostly manual testing, but verified the following:
WebUI.Backendto the demo network. Doesn't make sense today, but in case in the future we want to spin up the WebUI server in a separate process from the orchestrator