Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

클레임에 이메일, 이름, 유저명 추가 #236

Merged
merged 5 commits into from
Aug 19, 2023
Merged

Conversation

whnbaek
Copy link
Contributor

@whnbaek whnbaek commented Aug 13, 2023

높은 확률로 안됨

Copy link
Member

@nevivurn nevivurn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

가능하면 테스트가 있었으면 좋겠지만 oidc 테스트하기 어려우니 어쩔 수 없군요
dev에 나중에 올려보고 이상한 데이터 추가해서 테스트해볼 수 있을 것 같습니다
scope 설정은 로컬에서 태스트 가능한데 해보신건가요?

src/oidc/configuration.ts Outdated Show resolved Hide resolved
@whnbaek whnbaek requested review from nevivurn and removed request for tirr-c August 13, 2023 16:26
@whnbaek
Copy link
Contributor Author

whnbaek commented Aug 13, 2023

@nevivurn 테스트 안해봤습니다. dev에 올려서 직접 테스트하겠다는 의지이지요.

src/oidc/configuration.ts Outdated Show resolved Hide resolved
src/oidc/configuration.ts Outdated Show resolved Hide resolved
src/oidc/configuration.ts Outdated Show resolved Hide resolved
src/oidc/configuration.ts Outdated Show resolved Hide resolved
@tirr-c
Copy link
Contributor

tirr-c commented Aug 14, 2023

포매터도 돌려주세요~ yarn fmt

@whnbaek whnbaek merged commit 457bcac into master Aug 19, 2023
3 checks passed
@whnbaek whnbaek deleted the feat/oauth_claim branch August 19, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants