-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
클레임에 이메일, 이름, 유저명 추가 #236
Merged
Merged
클레임에 이메일, 이름, 유저명 추가 #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nevivurn
requested changes
Aug 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
가능하면 테스트가 있었으면 좋겠지만 oidc 테스트하기 어려우니 어쩔 수 없군요
dev에 나중에 올려보고 이상한 데이터 추가해서 테스트해볼 수 있을 것 같습니다
scope 설정은 로컬에서 태스트 가능한데 해보신건가요?
@nevivurn 테스트 안해봤습니다. dev에 올려서 직접 테스트하겠다는 의지이지요. |
tirr-c
reviewed
Aug 14, 2023
Co-authored-by: Wonwoo Choi <[email protected]>
tirr-c
requested changes
Aug 14, 2023
포매터도 돌려주세요~ |
tirr-c
approved these changes
Aug 14, 2023
nevivurn
approved these changes
Aug 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
높은 확률로 안됨