Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

username and groups claim moved inside openid scope #240

Merged
merged 1 commit into from
Aug 21, 2023
Merged

username and groups claim moved inside openid scope #240

merged 1 commit into from
Aug 21, 2023

Conversation

whnbaek
Copy link
Contributor

@whnbaek whnbaek commented Aug 20, 2023

No description provided.

@whnbaek whnbaek requested review from nevivurn and removed request for nevivurn August 20, 2023 20:23
tirr-c
tirr-c reviewed Aug 21, 2023
View reviewed changes
Copy link
Contributor

@tirr-c tirr-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conformIdTokenClaims: false는 여기서 하는 게 아닌가요?

@whnbaek
Copy link
Contributor Author

whnbaek commented Aug 21, 2023

conformIdTokenClaims: false를 안하기로 했어요. 그냥 username이랑 groups는 oidc scope로 옮기고 나머지는 그대로 유지해서 profile이랑 email을 얻으려면 access token으로 userinfo endpoint에서 얻도록 했어요.

@whnbaek whnbaek merged commit 89e9d1e into master Aug 21, 2023
3 checks passed
@whnbaek whnbaek deleted the feat/oidc-claim-move branch August 21, 2023 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tirr-c tirr-c tirr-c approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@whnbaek @tirr-c