Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ES Modules 방식으로 마이그레이션 #258

Merged
merged 5 commits into from
Mar 27, 2024
Merged

ES Modules 방식으로 마이그레이션 #258

merged 5 commits into from
Mar 27, 2024

Conversation

tirr-c
Copy link
Contributor

@tirr-c tirr-c commented Mar 24, 2024 •
edited
Loading

  • package.json에 "type": "module" 추가
  • relative import에 모두 확장자 추가
  • module only package인 oidc-provider 임포트 방식 변경
  • type only import에 모두 type 표시 (verbatimModuleSyntax)

트랜스파일 결과물이 아주 깔끔합니다.

@tirr-c tirr-c self-assigned this Mar 24, 2024
seojangho
seojangho approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@seojangho seojangho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@tirr-c tirr-c merged commit 63f4e1b into master Mar 27, 2024
2 checks passed
@tirr-c tirr-c deleted the es-modules branch March 27, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seojangho seojangho seojangho approved these changes

Assignees

@tirr-c tirr-c

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tirr-c @seojangho