Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update failing test to use package iptables in [archlinux] #10616

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

jNullj
Copy link
Collaborator

@jNullj jNullj commented Oct 16, 2024

use iptables as its a stable long term package that uses more standard version numbers
archlinux uses upstream versions which makes version regex for tests hard to predict

see also failed test at https://github.com/badges/shields/actions/runs/11364173280?pr=10615
in PR #10615

see also https://wiki.archlinux.org/title/PKGBUILD#Version for info about pkg versions. might include letters and dates rather then fixed regex.

use iptables as its a stable long term package that uses more standard version numbers
archlinux uses upstream versions which makes version regex for tests hard to predict
@jNullj jNullj changed the title update failing test to use package iptables update failing test to use package iptables in [archlinux] Oct 16, 2024
@jNullj jNullj added keep-service-tests-green Related to fixing failing tests of the services javascript Pull requests that update Javascript code labels Oct 16, 2024
Copy link
Contributor

Messages
📖 ✨ Thanks for your contribution to Shields, @jNullj!

Generated by 🚫 dangerJS against 59699ca

@chris48s chris48s added this pull request to the merge queue Oct 16, 2024
Merged via the queue into badges:master with commit 0a57af2 Oct 16, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code keep-service-tests-green Related to fixing failing tests of the services
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants