Make children immutable to avoid concurrent modification exception #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d check if Node has been destroyed before calling lifecycle events
CherryPerry
reviewed
Mar 20, 2023
| @@ -237,7 +256,8 @@ open class Node<V : RibView> @VisibleForTesting internal constructor( | |||
| @MainThread | |||
| fun attachChildNode(child: Node<*>) { | |||
| verifyNotRoot(child) | |||
| _children.add(child) | |||
| val newChildren = children.toMutableList().apply { add(child) } | |||
There was a problem hiding this comment.
children + child instead?
| @@ -99,6 +99,8 @@ open class Node<V : RibView> @VisibleForTesting internal constructor( | |||
| is AncestryInfo.Child -> ancestryInfo.anchor | |||
| } | |||
|
|
|||
| private var isDestroyed: Boolean = false | |||
There was a problem hiding this comment.
get() = lifecycleManager.ribLifecycle.state == Lifecycle.DESTROYED to eliminate possibility of desynchronisation of properties.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make children immutable to avoid concurrent modification exception and check if Node has been destroyed before calling lifecycle events
Description:
Related issue(s):