Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InputFormula 公式编辑器 添加clearDefaultFormula 属性，可清除默认函数 #8035

Open
wants to merge 29 commits into
base: master
Choose a base branch
from

去除log

c666796
Select commit
Loading
Failed to load commit list.
Open

InputFormula 公式编辑器 添加clearDefaultFormula 属性，可清除默认函数 #8035

去除log
c666796
Select commit
Loading
Failed to load commit list.
Deleted GitHub App / Copilot for PRs succeeded Sep 7, 2023 in 1m 12s

Analysis complete

Summary

Added a new feature to the input-formula component and its documentation. The feature allows users to clear the default functions from the formula editor and picker. The feature can be configured in the schema or in the component props. The feature required a new dependency rc-component and a modification of the test case.

Walkthrough

  • Removed the unnecessary scope="body" attribute from the schema code blocks in the documentation file docs/zh-CN/components/form/input-formula.md (link, link, link, link, link, link, link, link)

  • Added a new clearDefaultFormula property to the input-formula component, which allows to clear the default functions and use only the custom ones defined in the functions property (link, link, link, link, link, link, link, link, link, link, link, link, link)

  • Added a new dependency rc-component to the package.json file, which is required for the input-formula component (link)

    Poem

    We're coding up a storm, me hearties, with rc-component

We're adding and removing props, to make the formula perfect
Heave ho, and clear the default, on the count of three
We're building a fine input-formula, for all to see

Emoji

🆕🧹📝

Include these descriptions in your pull request description by including the following marker tags:

  • copilot:all: all the content, in one go
  • copilot:summary: a one paragraph summary of the code changes
  • copilot:walkthrough: a step by step walkthrough of the code changes
  • copilot:poem: a poem about the code changes!
  • copilot:emoji: three emoji that capture the changes

Feedback is welcome. Simply add a comment to this PR of the form /copilot feedback [your comments here].

Details

Copilot for PRs is a limited technical preview from GitHub Next.

It's aim is to make it easier to write pull request descriptions by providing automatically generated suggestions based on the code changes.

To find out more go to https://githubnext.com/projects/copilot-for-pull-requests or come and chat with us on Discord

Progress:

File Status Duration
Summary & Walkthrough ✅ Finished 67.7 seconds
docs/zh-CN/components/form/input-formula.md ✅ Finished 57.8 seconds
package.json ✅ Finished 55.7 seconds
packages/amis-formula/src/doc.ts 🤷‍♂️ Skipped (change too big) 0 seconds
packages/amis-ui/src/components/formula/Editor.tsx ✅ Finished 57 seconds
packages/amis-ui/src/components/formula/Picker.tsx ✅ Finished 57.4 seconds
packages/amis/tests/renderers/Form/inputFormula.test.tsx ✅ Finished 55.7 seconds
packages/amis/src/renderers/Form/InputFormula.tsx ✅ Finished 57.6 seconds

⚠️ The file packages/amis-formula/src/doc.ts was skipped. 2032 lines were added or removed, with the largest change updating 400 lines.