issue=#1281: add observer implement, including executor, multi-thread scan and trigger calculation etc. #1288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/observer/executor/scanner.cc
Outdated
| bool ret = true; | ||
| tera::ScanDescriptor desc(start_key); | ||
| desc.SetAsync(FLAGS_observer_scan_async_switch); | ||
| // Notify�д洢�ڵ���lg |
elithnever
reviewed
Jun 21, 2017
include/observer/observer.h
Outdated
| class Observer { | ||
| public: | ||
| // ����۲���Ψһ��ʾ���Լ����۲��� | ||
| Observer(const std::string& observer_name, ColumnList& observed_columns); |
There was a problem hiding this comment.
observed_columns放在构造函数里参数不太好, 作为observe的参数比较好
include/observer/executor.h
Outdated
| namespace observer { | ||
|
|
||
| /// ִ���� | ||
| class Executor { |
include/observer/observer.h
Outdated
| virtual bool Init(); | ||
|
|
||
| // �û�ʵ�ִ˽ӿ��������� | ||
| virtual bool Close(); |
| } | ||
|
|
||
| bool Observer::Ack(ColumnList& columns, const std::string& row, int64_t timestamp) { | ||
| return ExecutorImpl::SetOrClearNotification(columns, row, timestamp, kClearNotification); |
src/observer/executor/tuple.h
Outdated
| int64_t timestamp; | ||
| }; | ||
|
|
||
| typedef boost::shared_ptr<Tuple> TuplePtr; |
include/observer/observer.h
Outdated
| virtual ~Observer(); | ||
|
|
||
| // �û�ʵ�ִ˽ӿ��õ��۲����ϱ仯���, ��ɼ��� | ||
| virtual bool OnNotify(tera::Transaction* t, |
| } | ||
|
|
||
| bool Observer::OnNotify(tera::Transaction* t, | ||
| tera::Table* table, |
There was a problem hiding this comment.
应该不需要传table的指针, 可以传入tablename, observer读写tera都通过transaction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.