bugfix: teracli exit will core #737
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#735 |
| @@ -19,6 +19,10 @@ void TabletNodeClient::SetRpcOption(int32_t max_inflow, int32_t max_outflow, | |||
| pending_buffer_size, thread_num); | |||
| } | |||
|
|
|||
| void TabletNodeClient::Shutdown() { | |||
There was a problem hiding this comment.
RpcClientBase是TabletNodeClient和MasterClient共享的，所以这么改并不合适，实际上上面的SetRpcOption函数也没有存在的意义，正确的做法是直接调RpcClientBase::SetOption和RpcClientBase::Shutdown
|
哈哈，建议先把这个版本给报问题的用户试试，没问题的话再评论。 |
|
这个有进展么 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.