Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test rpcs #405

Merged
merged 4 commits into from
Jul 28, 2023
Merged

Update test rpcs #405

merged 4 commits into from
Jul 28, 2023

Conversation

johngrantuk
Copy link
Member

  • Update .env RPC vars to be provider agnostic. Now we use:
    • RPC_URL_MAINNET (required for tests and local node script)
    • RPC_URL_POLYGON (required for tests and local node script)
    • Others can be added to run examples
  • A lot of tests referencing infura in provider didn't actually need a valid provider so have been changed to empty string

@johngrantuk johngrantuk merged commit 6e7da54 into develop Jul 28, 2023
3 checks passed
@johngrantuk johngrantuk deleted the update-test-rpcs branch July 28, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgahdl lgahdl lgahdl approved these changes

@brunoguerios brunoguerios Awaiting requested review from brunoguerios

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johngrantuk @lgahdl