Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing the code with less precision and uncommenting the code with … #434

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

lgahdl
Copy link
Contributor

@lgahdl lgahdl commented Mar 7, 2024

…more precision

Copy link
Member

@johngrantuk johngrantuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does seem promising! It also fixes the consistently failing example I have. You'll need to investigate the regression with the failing tests though. Let us know how you get on!

@lgahdl
Copy link
Contributor Author

lgahdl commented Mar 7, 2024

This does seem promising! It also fixes the consistently failing example I have. You'll need to investigate the regression with the failing tests though. Let us know how you get on!

Since all tests failed with hardcoded values, and the result values were very close to the hardcoded one, I changed the hardcoded values, let me know if I should take another approach

@lgahdl lgahdl requested a review from johngrantuk March 7, 2024 19:03
@brunoguerios
Copy link
Member

Nice that you found the issue 👏
Hardcoded values do seem pretty close - I'd say updating them so tests pass should be ok 👍

Luiz Gustavo Abou Hatem De Liz added 2 commits March 11, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants