-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs on increasing the persistent log sizes #2263
Conversation
Hey @lmbarros not to put too much on your plate since you are looking to persistent logging maybe answers to these questions by Zoobot would be great to be documented |
@lmbarros Repinging for about finishing this. Let me know if you need help. |
@vipulgupta2048 What are the Zoobot's questions you mentioned? The current status here is that I am getting errors when following the instructions on README to test and rebuild the docs after my changes. After a successful
And
|
Signed-off-by: Leandro Motta Barros <[email protected]> Change-type: patch
162abe4
to
c187c5c
Compare
Thanks, @vipulgupta2048 ! Ready for review! I didn't take into account Zoobot's questions (have higher-prio tasks now), but I think this PR is an improvement over the current docs nevertheless. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lmbarros for your contribution!
@vipulgupta2048 Would you mind elaborating on why the steps for increasing the size of persistent logs should only work on development images? I tested these steps today on a production image and they seem to work. |
Hello @Maher4Ever Looking back on this change, it seemed @lmbarros might have tested it on development/production and found something. So pinging to see if he knows something. I was under the impression changing the setting should work in any environment. Since you have tested it and if you can then please do open a PR to rectify this. |
Hi @Maher4Ever ! As far as I know it should technically work in production mode, too. It's just that we currently don't offer a simple and safe way to change this config, and we generally recommend against manual config modifications to production devices (because mistakes can cause hard-to-solve problems). |
No description provided.